Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RxSwift an optional dependency. #6

Open
levibostian opened this issue Oct 4, 2018 · 2 comments
Open

Make RxSwift an optional dependency. #6

levibostian opened this issue Oct 4, 2018 · 2 comments

Comments

@levibostian
Copy link
Owner

RxSwift is a library some people may not want to use. I also enjoy creating libraries that do not have dependencies on them if I can help it.

Therefore, let's remove RxSwift from the core of the library and make it a separate module that devs can use if they wish.
@levibostian
Copy link
Owner Author

Work on this issue before this to make this issue very easy to do since there will be protocols which will allow us to separate the core and Rx based modules easily.

@levibostian
Copy link
Owner Author

Inspiration:

  • Moya - Moya uses a protocol, TargetType, that you implement and then provide to Moya via rx extension MoyaProvider.rx.request(targetType).subscribe{}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levibostian