Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files for compilation #3

Closed
RockyRoad29 opened this issue Dec 18, 2016 · 1 comment
Closed

Missing files for compilation #3

RockyRoad29 opened this issue Dec 18, 2016 · 1 comment

Comments

@RockyRoad29
Copy link

RockyRoad29 commented Dec 18, 2016

Hi leesavide,

A big thanks for maintaining git versionning for abc tools.

However I was not able to compile abcm2ps from the cloned repo.

Comparing with the contents of abcm2ps-8.13.1.tar.gz, there where two missing files:

  • Makefile.in
  • config.h.in

Actually they were excluded in your .gitignore file (a bit bulky to my taste if I may say).
Also maybe Makefile should not be versionned since it is generated, but it is included in official source, so I left it in.

Here is my proposed patch (git diff):
compilable.patch.txt

Hope this helps

@lewdlime
Copy link
Owner

lewdlime commented Dec 27, 2016

Thank you for telling me about this: I only just realized that the .gitignore file had them ignored. I've re-pushed the latest version with the missing Makefile.in & config.in files, but I do not have enough mastery over Git to fix the issue with past commits. ☹️

The main focus on this repository is to show changes in code between versions, rather than be an active repository that would try to replace Jean-François Moine's own website. As such, anytime he updates his code from his website, I copy the files from the new archive, commit & tag them, then push, since I do not take any credit for writing the code, which is why the Makefile is left in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants