Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate reactor icon support #1473

Open
a-sr opened this issue Nov 15, 2022 · 1 comment
Open

Reactivate reactor icon support #1473

a-sr opened this issue Nov 15, 2022 · 1 comment
Assignees
@a-sr
Labels
diagrams Problems with diagram synthesis

Comments

@a-sr
Copy link
Collaborator

a-sr commented Nov 15, 2022 •
edited
Loading

The code for user-defined reactor icons was diabled in PR #1469 because it relies on Eclipse-specific image data and is not supported Klighd VS Code, see kieler/KLighD#146.
As soon as Klighd provides an API for image sources that will work with a language server (i.e. kieler/KLighD#146 fixed), the icon support should be reactivated.
@a-sr a-sr added the diagrams Problems with diagram synthesis label Nov 15, 2022
@a-sr a-sr self-assigned this Nov 15, 2022
@a-sr a-sr mentioned this issue Nov 15, 2022
Merged
@NiklasRentzCAU
Copy link

Correction: This relates to kieler/KLighD#146 and not 144.

@a-sr a-sr mentioned this issue Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-sr a-sr

Labels
diagrams Problems with diagram synthesis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-sr @NiklasRentzCAU