Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the notion of boost in the choice of the featured quest #779

Closed
fricoben opened this issue Jul 31, 2024 · 5 comments · Fixed by #796
Closed

Add the notion of boost in the choice of the featured quest #779

fricoben opened this issue Jul 31, 2024 · 5 comments · Fixed by #796
Assignees
Labels
Good first issue Good for newcomers 🍒 Nice to have Nice to have but not a priority open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

fricoben commented Jul 31, 2024

Description

The featured quest is the quest shown first on the Starknet quest home page as so:

Capture d’écran 2024-07-31 à 12 18 46

Currently, this place shows randomly non-expired quests, I want you to refactor the QuestProvider.tsx code here line 104

Capture d’écran 2024-07-31 à 12 18 07

So we do not feature a random non-expired quest but the last boosted quest and if no boosted quest is available then we feature a random non-expired quest. Moreover this code

    const notExpired = quests.filter((quest) => !quest.expired);
    const randomQuest =
      notExpired[Math.floor(Math.random() * notExpired.length)];
    setFeaturedQuest(randomQuest);

Is repeated two times in two different useMemos, I don't think it's necessary so you may delete one.

This is a pretty fast issue, don't hesitate to use GPT to make a clean code.

@fricoben fricoben added 🍒 Nice to have Nice to have but not a priority open for contribution An issue that is available for an Only Dust contribution labels Jul 31, 2024
@Iwueseiter
Copy link
Contributor

Iwueseiter commented Jul 31, 2024

Please can I work on this? @fricoben
I’d push a PR quickly.

@fricoben fricoben added the Good first issue Good for newcomers label Jul 31, 2024
@petersdt
Copy link
Contributor

petersdt commented Jul 31, 2024

@fricoben can i work on this

@ShantelPeters
Copy link
Contributor

ShantelPeters commented Jul 31, 2024

@fricoben This is my first time contributing to this ecosystem.. can I be assigned to this issue…
I will push a PR between 3-5 working days after Been assigned

@Mystic-Nayy
Copy link
Contributor

Hi @fricoben i am a frontend developer, I can handle this issues if I am being assigned, this will be my first issue on this project

@fricoben
Copy link
Contributor Author

assigned to @Gift-Naomi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers 🍒 Nice to have Nice to have but not a priority open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants