Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuLIP Dependency #3

Closed
cortner opened this issue Aug 1, 2021 · 5 comments
Closed

JuLIP Dependency #3

cortner opened this issue Aug 1, 2021 · 5 comments

Comments

@cortner
Copy link
Member

cortner commented Aug 1, 2021

I think it may be worth removing the JuLIP dependency. There is some discussion about implementing a few abstract atoms and structure interfaces that will be shared, that that one could depend on, but JuLIP will not be taken up by the community. I'll most likely retire it in the near future. Instead - until then - we can import ExtXYZ.jl from JuLIP and add JuLIP-specific wrappers.

@jameskermode
Copy link
Member

Good idea- that was roughly my plan. I’ll separate the JuLIP stuff and make a PR

@jameskermode
Copy link
Member

In fact I see the file IO code in JuLIP is imported from ACEbase.FIO and then re-exported by JuLIP. Would it be better for me to make a PR against ACEbase rather than JuLIP?

@jameskermode
Copy link
Member

Never mind, I see that nothing in ACEbase is specific to Atoms, so it should go somewhere near JuLIP.FIO.read_dict().

@cortner
Copy link
Member Author

cortner commented Aug 3, 2021

Correct, ACEbase was just created to put some codes that I need in ACE and JuLIP since I've disentangled ACE now completely from being about Atoms.

I also don't mind if you want to create a JuLIP.XYZ submodule. Happy either way.

@jameskermode
Copy link
Member

Closed by JuliaMolSim/JuLIP.jl#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants