-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JuLIP Dependency #3
Comments
Good idea- that was roughly my plan. I’ll separate the JuLIP stuff and make a PR |
In fact I see the file IO code in JuLIP is imported from |
Never mind, I see that nothing in |
Correct, ACEbase was just created to put some codes that I need in ACE and JuLIP since I've disentangled ACE now completely from being about Atoms. I also don't mind if you want to create a JuLIP.XYZ submodule. Happy either way. |
Closed by JuliaMolSim/JuLIP.jl#142 |
I think it may be worth removing the JuLIP dependency. There is some discussion about implementing a few abstract atoms and structure interfaces that will be shared, that that one could depend on, but JuLIP will not be taken up by the community. I'll most likely retire it in the near future. Instead - until then - we can import ExtXYZ.jl from JuLIP and add JuLIP-specific wrappers.
The text was updated successfully, but these errors were encountered: