Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup coverage tracking #31

Closed
mfherbst opened this issue Feb 5, 2023 · 3 comments · Fixed by #43
Closed

Setup coverage tracking #31

mfherbst opened this issue Feb 5, 2023 · 3 comments · Fixed by #43

Comments

@mfherbst
Copy link
Contributor

mfherbst commented Feb 5, 2023

It would be useful to find bug such as the one fixed in #30 to setup automatic coverage tracking in the package.
@jameskermode
Copy link
Member

Happy to do this. Do you have an example to hand?

@mfherbst
Copy link
Contributor Author

mfherbst commented Feb 5, 2023

I think it's just this:

https://github.com/mfherbst/ASEconvert.jl/blob/3c4e21aaaf1dad32e1802284410c471e3fcdc66e/.github/workflows/CI.yml#L36--L39

and you have to enable codecov for this project.

@mfherbst
Copy link
Contributor Author

mfherbst commented Feb 5, 2023

In fact I think I already perpared this in the CI when I did the refactor in #29 .

@jameskermode jameskermode linked a pull request Sep 20, 2023 that will close this issue
codecov #43
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codecov libAtoms/ExtXYZ.jl
2 participants
@jameskermode @mfherbst