Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xyz file produced by LAMMPS cannot be parsed #35

Open
mfherbst opened this issue Apr 8, 2023 · 2 comments
Open

xyz file produced by LAMMPS cannot be parsed #35

mfherbst opened this issue Apr 8, 2023 · 2 comments

Comments

@mfherbst
Copy link
Contributor

mfherbst commented Apr 8, 2023

Hi @jameskermode. In AtomsIO I received mfherbst/AtomsIO.jl#19, which essentially is a parsing failure in ExtXYZ for an xyz file produced by LAMMPS --- so something I'd argue we would want to support.

Here is a simplified reproducer:

1
Atoms. Timestep: 1000000
Ar    1.4102613692638457    0.9647607662828660    1.3209769521273491

where the error message printed is:

Failed to parse string at pos 7
@ejmeitz
Copy link

ejmeitz commented Oct 31, 2023

I would also use this feature. If it's something easy to change I can make the PR.

@jameskermode
Copy link
Member

jameskermode commented Nov 6, 2023

Thanks for the reminder @ejmeitz. I implemented most of what is needed in libAtoms/extxyz#16 but need to make a new release of libextxyz and then update ExtXYZ.jl to use it. What is blocking this at the moment is the failures to build on Windows in libAtoms/extxyz#17, so if you have the time or expertise to help with that this would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants