Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SOFA version 13 #45

Closed
mhvk opened this issue Apr 30, 2017 · 5 comments
Closed

Update to SOFA version 13 #45

mhvk opened this issue Apr 30, 2017 · 5 comments

Comments

@mhvk
Copy link
Contributor

mhvk commented Apr 30, 2017

As noted by @rmathar (#44 (comment)), SOFA version 13 is out, and we should update ERFA to it, since it solves #40 and #41. It is also a good opportunity to finally get in #42...

@bsipocz
Copy link

bsipocz commented Jun 16, 2017

@mhvk @eteq - Is there any chance to get a new erfa version out to bundle with astropy v2.0?

@mhvk
Copy link
Contributor Author

mhvk commented Jun 16, 2017

We should -- but I fear I won't be able to do it...

@eteq
Copy link
Member

eteq commented Jun 16, 2017

@bsipocz @mhvk - we could pull it into master today (and pull it into Astropy), but I don't think I can do the full release. So it depends on whether we want a "pre-released" version in Astropy. (We'd still have 2 weeks to iron out any changes, since those could be post feature-freeze but pre-Astropy release). I don't see that as a new "feature".

@astrofrog or @taldcroft might want to weigh in too, given that it's an Astropy procedural question

@bsipocz
Copy link

bsipocz commented Jun 16, 2017

I feel that your proposal is fine for feature freeze, given if you can do a full release before we have final v2.0. (Updating externals doesn't seem to be a new feature to me, but erfa is critical enough that we need the RC testing for it I think.)

@mhvk
Copy link
Contributor Author

mhvk commented Jun 16, 2017

Agreed with @bsipocz - pre-release should be fine. I think it would be very good to have even just the erfa version exposed in astropy 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants