-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compiler_flags setting take precedence over the compiler flag env var #622
Make compiler_flags setting take precedence over the compiler flag env var #622
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 77.31% 77.32%
=======================================
Files 265 265
Lines 19592 19594 +2
=======================================
+ Hits 15148 15151 +3
+ Misses 4444 4443 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the flags for the SYCL backend should also be updated also.
void setCompilerFlags(occa::json &dpcpp_properties) noexcept |
(Currently Metal and OpenMP don't have their own env variables for compiler flags).
Done. |
@MalachiTimothyPhillips can you set your PR to merge into development. |
Done. Please let me know if you need anything else. Cheers! |
…v var (#622) * Make compiler_flags setting take precedence over the compiler flag env var * Apply same change to SYCL backend.
…v var (#622) * Make compiler_flags setting take precedence over the compiler flag env var * Apply same change to SYCL backend.
Closes #621