Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Discovery shouldn't tag relays #72

Open
vyzo opened this issue Apr 26, 2019 · 2 comments
Open

Discovery shouldn't tag relays #72

vyzo opened this issue Apr 26, 2019 · 2 comments

Comments

@vyzo
Copy link
Contributor

vyzo commented Apr 26, 2019

We have this code: https://github.com/libp2p/go-libp2p-circuit/blob/master/notify.go#L49
which tags all relays discovered with passive discovery.

This was useful before autorelay, but it seems to result in a large number of idle connections.

What was the rationale for it?
I suggest we remove this tag.

cc @whyrusleeping who added the tag, @Stebalien

@Stebalien
Copy link
Member

We probably added it assuming that we're more likely to connect to peers behind relays than not. These nodes are strictly more useful.

Given the low tag value, I'm happy either way.

@vyzo
Copy link
Contributor Author

vyzo commented Apr 30, 2019

yeah, not binding. I am not dead set on removing them either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants