Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new fn similar to Provide that doesn't only support peerIDs, but also []byte values #718

Open
itsmeadi opened this issue May 20, 2021 · 0 comments

Comments

@itsmeadi
Copy link

itsmeadi commented May 20, 2021

Currently we have

  • dht.PutValue(key, value) // put/override existing value
  • dht.Provide(key) // append but only supports peerID

What if we implement a third fn

  • dht.Append(key, value)
    It will be similar to Provide, just we store a value instead of peerID, so that when we try
  • dht.AppendGet(key)[]Value
    We get a list of values

I did a small POC on my local, replacing peer.ID with a string value in Provide and its child functions, it seems working but i need help from you guys, is this a right approach, or any pitfalls I am not seeing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant