Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Add "handshake seal" #7

Closed
yusefnapora opened this issue Dec 4, 2019 · 1 comment
Closed

Add "handshake seal" #7

yusefnapora opened this issue Dec 4, 2019 · 1 comment

Comments

@yusefnapora
Copy link
Contributor

libp2p/specs#234 adds a new requirement to the spec, which we should implement here.

To prevent replay attacks & tampering of handshake messages, we sign the Noise HandshakeHash with the libp2p key and send the signature before any ciphertexts are exchanged over the secure channel. Each party will verify the signature against their own HandshakeHash, which proves that both parties have the same view of the handshake exchange and that nothing has been altered.

@yusefnapora
Copy link
Contributor Author

Oh, also, we should update the protobuf field names to match the changes in libp2p/specs#234 while we're at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant