Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: flaky TestDialExistingConnection #1431

Closed
marten-seemann opened this issue Apr 22, 2022 · 1 comment · Fixed by #1491
Closed

swarm: flaky TestDialExistingConnection #1431

marten-seemann opened this issue Apr 22, 2022 · 1 comment · Fixed by #1491
Assignees
@vyzo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor 

  === RUN   TestDialExistingConnection
      dial_test.go:490: 
          	Error Trace:	dial_test.go:490
[...] 20k lines
          	Test:       	TestDialExistingConnection
          	Messages:   	expecting the same connection from both dials
  --- FAIL: TestDialExistingConnection (0.21s)
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Apr 22, 2022
@marten-seemann marten-seemann changed the title flaky TestDialExistingConnection swarm: flaky TestDialExistingConnection Apr 22, 2022
@marten-seemann
Copy link
Contributor Author

There's also a race condition: https://gist.github.com/marten-seemann/963480ecb9223ebc7a66546e4934220c

@marten-seemann marten-seemann mentioned this issue May 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyzo vyzo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm: fix flaky and racy TestDialExistingConnection libp2p/go-libp2p
2 participants
@vyzo @marten-seemann