Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for circuit v1 #2075

Closed
Tracked by #2062
marten-seemann opened this issue Feb 8, 2023 · 5 comments · Fixed by #2107
Closed
Tracked by #2062

drop support for circuit v1 #2075

marten-seemann opened this issue Feb 8, 2023 · 5 comments · Fixed by #2107

Comments

@marten-seemann
Copy link
Contributor

marten-seemann commented Feb 8, 2023

We're retired all Circuit v1 Relays a few months ago. rust-libp2p has dropped support and js-libp2p is dropping support for v1 support. We should do the same in go-libp2p.

@fahimbagar
Copy link

fahimbagar commented Feb 10, 2023

Hi @marten-seemann 👋

I'm excited to have go-libp2p v0.26, so that's why I've worked on this issue.
This is the PR for this remove support for Circuit Relay v1 protocol: #2083

Let me know if I'm missing something there. Thanks

@marten-seemann
Copy link
Contributor Author

@fahimbagar Please comment on the issue before picking up the work. I already have a branch that removed support, just hadn’t pushed the changes. That’s now wasted duplicate work.

@fahimbagar
Copy link

fahimbagar commented Feb 10, 2023

Understood. I can close the PR, no worries. I'm just trying to understand the libp2p deeper by working on this issue.

Closing the PR, I'll comment first if I want to pick up the PR. Thanks for the advice.

@marten-seemann
Copy link
Contributor Author

Hi @fahimbagar! Sorry for the misunderstanding. We're actually really happy about new contributors, so please don't take this the wrong way.

We have a bunch of issues with the "help wanted" label, those are generally good ones to get started on the code base. Let me know if you want to pick up any of those (either on the issue, or message me on our Slack).

@fahimbagar
Copy link

Hi @fahimbagar! Sorry for the misunderstanding. We're actually really happy about new contributors, so please don't take this the wrong way.

It's my fault 😅 I should ask before I pick up any of the issues.

We have a bunch of issues with the "help wanted" label, those are generally good ones to get started on the code base. Let me know if you want to pick up any of those (either on the issue, or message me on our Slack).

Sure, I'll try to see the help-wanted issues sometime this week. Thanks for the information, Marten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants