Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autorelay: deadlock in tests #2167

Closed
marten-seemann opened this issue Mar 3, 2023 · 1 comment · Fixed by #2171
Closed

autorelay: deadlock in tests #2167

marten-seemann opened this issue Mar 3, 2023 · 1 comment · Fixed by #2171
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

https://github.com/libp2p/go-libp2p/actions/runs/4321376917/jobs/7542536126
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Mar 3, 2023
@sukunrt
Copy link
Member

sukunrt commented Mar 4, 2023 •
edited
Loading

Sorry. I introduced this here:
#2164

The deadlock is swarm.notifyAll has swarm.notifee lock and calls disconnected on relay service which depends on relay service lock
The relay service Close has relay service lock and calls swarm.stopNotify which depends on swarm.notifee lock.

@sukunrt sukunrt mentioned this issue Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relay: fix deadlock when closing sukunrt/go-libp2p
2 participants
@marten-seemann @sukunrt