Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update quic-go to v0.36.1 #2318

Closed
Tracked by #2326
marten-seemann opened this issue Jun 1, 2023 · 4 comments
Closed
Tracked by #2326

update quic-go to v0.36.1 #2318

marten-seemann opened this issue Jun 1, 2023 · 4 comments
Assignees
@MarcoPolo
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@marten-seemann
Copy link
Contributor

quic-go just released a major refactor of the connection establishment API: https://github.com/quic-go/quic-go/releases/tag/v0.35.0.

This upgrade will require some work, since we now can't (and must not) reuse the same net.UDPConn for multiple dial / listen calls. Before v0.35.0 this was the way to reuse one underlying connection, but now this behavior is made explicit via the quic.Transport.
This was referenced Jun 1, 2023
Closed
Closed
@marten-seemann
Copy link
Contributor Author

@MarcoPolo Would you be able to take this issue? It would be great to see if the new quic-go API is actually usable and understandable by someone who hasn't designed it.

@marten-seemann marten-seemann added kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels Jun 15, 2023
@MarcoPolo
Copy link
Collaborator

Can do

@marten-seemann marten-seemann changed the title update quic-go to v0.35 update quic-go to v0.36 Jun 21, 2023
@marten-seemann
Copy link
Contributor Author

We should hold off on v0.36.0, since there's still a GSO issue that needs to be resolved: quic-go/quic-go#3911. We can go ahead with v0.35.1 though, there's no breaking API change between v0.35.1 and v0.36.0 that would concern us in libp2p, so that upgrade will be trivial.

@p-shahi p-shahi changed the title update quic-go to v0.36 update quic-go to v0.35 Jun 27, 2023
@marten-seemann
Copy link
Contributor Author

quic-go v0.36.1 disables GSO by default, and should be safe to use in go-libp2p.

@marten-seemann marten-seemann changed the title update quic-go to v0.35 update quic-go to v0.36.1 Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo MarcoPolo

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcoPolo @marten-seemann