Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(dev)!: bump aegir from 37.12.1 to 38.1.0 #82

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2023

Bumps aegir from 37.12.1 to 38.1.0.

Release notes

Sourced from aegir's releases.

v38.1.0

38.1.0 (2023-01-12)

Features

  • Add support for compiling Typescript snippets in markdown (#1134) (055e1d5)

v38.0.0

38.0.0 (2023-01-12)

⚠ BREAKING CHANGES

    • no more forwarding flags
  • no more positional arguments - cannot depcheck single file
  • won't throw an error for missing dependency if it's in devDependencies section of package.json

Co-authored-by: Alex Potsides [email protected]

  • all functions and methods need to declare a return type

Features

  • add support for depchecking typescript projects (#1042) (b9f5d86)

Dependencies

Changelog

Sourced from aegir's changelog.

38.1.0 (2023-01-12)

Features

  • Add support for compiling Typescript snippets in markdown (#1134) (055e1d5)

38.0.0 (2023-01-12)

⚠ BREAKING CHANGES

    • no more forwarding flags
  • no more positional arguments - cannot depcheck single file
  • won't throw an error for missing dependency if it's in devDependencies section of package.json

Co-authored-by: Alex Potsides [email protected]

  • all functions and methods need to declare a return type

Features

  • add support for depchecking typescript projects (#1042) (b9f5d86)

Dependencies

Commits
  • 3f05125 chore(release): 38.1.0 [skip ci]
  • 055e1d5 feat: Add support for compiling Typescript snippets in markdown (#1134)
  • 1cf5c45 chore(release): 38.0.0 [skip ci]
  • b9f5d86 feat!: add support for depchecking typescript projects (#1042)
  • cf77bbb deps!: update to new linting rules (#1164)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [aegir](https://github.com/ipfs/aegir) from 37.12.1 to 38.1.0.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v37.12.1...v38.1.0)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 13, 2023
@achingbrain
Copy link
Member

This will be a breaking change when it goes out.

@achingbrain achingbrain changed the title deps(dev): bump aegir from 37.12.1 to 38.1.0 deps(dev)!: bump aegir from 37.12.1 to 38.1.0 Jan 17, 2023
@mpetrunic
Copy link
Member

This will be a breaking change when it goes out.

Should we enable check for unused dependencies in every repo?

By default, it's just checking for missing dependencies

package.json Outdated
@@ -126,17 +126,14 @@
"scripts": {
"clean": "aegir clean",
"lint": "aegir lint",
"dep-check": "aegir dep-check",
"dep-check": "aegir dep-check --unused",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change to make dep checking more comprehensive should be made in aegir, otherwise if we want it, we'll need to apply this to every package.json in every project which is a big job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this package.json check via web3-bot?
Else, we need to make yet another breaking change to aegir

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we are apply the same option to every single use of the command it should be the default.

There are only a handful of modules that have upgraded so far.

package.json Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 4255edc into master Feb 1, 2023
@achingbrain achingbrain deleted the dependabot/npm_and_yarn/aegir-38.1.0 branch February 1, 2023 09:49
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
## [5.0.0](v4.0.2...v5.0.0) (2023-02-01)

### ⚠ BREAKING CHANGES

* **dev:** bump aegir from 37.12.1 to 38.1.0 (#82)

### Dependencies

* **dev:** bump aegir from 37.12.1 to 38.1.0 ([#82](#82)) ([4255edc](4255edc))
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants