fix: remove timeouts from pubsub tests #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of waiting for 800ms for pubsub subscriptions to propagate, wait for the publisher to see the reviever in it's list of subscribers for a given topic. This is because sometimes in CI it can taker longer than 800ms for the subs list to update which causes the tests to be flaky.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
## [6.0.1](v6.0.0...v6.0.1) (2023-02-23) ### Bug Fixes * remove timeouts from pubsub tests ([#88](#88)) ([e1ac636](e1ac636))
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
that referenced
this pull request
Feb 23, 2023
Follow up to #88 - instead wait for both peers to see each other in their subscribed peers list.
achingbrain
added a commit
that referenced
this pull request
Feb 23, 2023
Follow up to #88 - instead wait for both peers to see each other in their subscribed peers list.
achingbrain
added a commit
that referenced
this pull request
Feb 23, 2023
Follow up to #88 - instead wait for both peers to see each other in their subscribed peers list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of waiting for 800ms for pubsub subscriptions to propagate, wait for the publisher to see the receiver in it's list of subscribers for a given topic.
This is because sometimes in CI it can taker longer than 800ms for the subs list to update which causes the tests to be flaky.