fix: start daemons in series #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store references to the daemon client in the return value of `Promise.all` and use them to stop the daemons after a test run - if one or more daemons fail to start, we lose all references to daemons that started successfully so cannot stop them and the test run hangs. Instead start them individually so we can tear down any that started successfully.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [7.0.2](v7.0.1...v7.0.2) (2023-02-28) ### Bug Fixes * start daemons in series ([#95](#95)) ([949b000](949b000))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store references to the daemon client in the return value of
Promise.alland use them to stop the daemons after a test run - if one or more daemons fail to start, we lose all references to daemons that started successfully so cannot stop them and the test run hangs.Instead start them individually so we can tear down any that started successfully.
Refs: libp2p/js-libp2p#1575