[conn-manager] peer value should be HOP-aware

[pgte]

A connection to another peer can host connections to other peers through the HOP transport.
When disconnecting from a peer, the value of that connections shouldn't be only the single value of that peer, but also should contain the value of all the peers that are connected through it.

First discussed here.

[dryajov]

I think there will be other types of transports/services that we want to make the peer aware off, dht is one that comes to mind. Should we generalize this issue, so we can track those here as well?

[pgte]

That's a great point, but perhaps we should create another issue for this one alone, mainly because I think this is a special case where we specifically value a connection that contains more connections.
And also because there are finer points to be discussed in that context that you brought up, like: Should we have internal values for peer connections? How do these combine with the user-defined values? Is the "value" a good model for this? Is the go approach of tagging a good generalisation? Etc..

Opened issue here: https://github.com/libp2p/js-libp2p-connection-manager/issues/11

[dryajov]

Sounds good :)

[serzero2007]

The implementation I have suggested to solve issue libp2p/js-libp2p-connection-manager#8 should solve this one as well.

[dryajov]

@serzero2007 I'm not sure how it will help in this case, this is mostly about singling out some peers/connections as being more important than others.

[serzero2007]

It is basically a framework that would allow for a subsystem to ensure the connection to a certain node will not be dropped. The circuit subsystem can implement it the way described above.

[wemeetagain]

This feature is available thru peer tagging. We prioritize / sort peers based on peer tag values for autoconnect / disconnect.