Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deps #18

Merged
merged 4 commits into from
Jan 31, 2020
Merged

chore: update deps #18

merged 4 commits into from
Jan 31, 2020

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Dec 6, 2019 •
edited by jacobheun
Loading

BREAKING CHANGE: api changed as attach is not needed anymore

Needs:

@vasco-santos
chore: update deps
8903698 
BREAKING CHANGE: api changed as attach is not needed anymore
@vasco-santos vasco-santos mentioned this pull request Dec 6, 2019
Merged
2 tasks
jacobheun
jacobheun approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor thing, otherwise this looks good

src/index.js Outdated Show resolved Hide resolved
@jacobheun jacobheun merged commit 61813b9 into master Jan 31, 2020
@jacobheun jacobheun deleted the chore/update-deps-20191203 branch January 31, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun