Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Memory leak in downstream stream-to-it #127

Closed
betamos opened this issue Mar 29, 2020 · 2 comments · Fixed by #133
Closed

Memory leak in downstream stream-to-it #127

betamos opened this issue Mar 29, 2020 · 2 comments · Fixed by #133
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/in-progress In progress

Comments

@betamos
Copy link

betamos commented Mar 29, 2020

Currently, stream-to-it has a memory leak in sink (and thus duplex) resulting in O(n) memory consumption on the sender side. The leak seems seems to live at least for the entire connection, and possibly after the connection is closed as well.
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP labels Apr 6, 2020
@jacobheun
Copy link
Contributor

I will try to look into stream-to-it this week.

@jacobheun
Copy link
Contributor

I submitted a fix for the issue in stream-to-it, alanshaw/stream-to-it#7

@jacobheun jacobheun added the status/in-progress In progress label Jul 11, 2020
@jacobheun jacobheun mentioned this issue Jul 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update dependencies libp2p/js-libp2p-tcp
2 participants
@betamos @jacobheun