This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: add browser-to-browser test for bi-directional communication #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcel-G
force-pushed
the
test/bidirectional-browser-to-browser
branch
from
2bc45b9
to
8bbd56a
Compare
Marcel-G
force-pushed
the
test/bidirectional-browser-to-browser
branch
3 times, most recently
from
80b4af8
to
85567a5
Compare
Fixes: libp2p#173 Before this change, connecting to a webRTC peer over a relay would result in two open connections to the peer. One private-to-private webRTC connection and one relayed connection (used for signalling). In the browser-to-browser example, dialling B -> A simply returns the first existing connection to A (Added when dialling A -> B). The first connection is not the webRTC connection but rather the relayed connection. This causes the echo to break after the relay is closed or after the reservation expires. After signalling is complete, the relayed peer connection is no longer needed and can be closed. The only connection to the peer is webRTC at this point.
Marcel-G
force-pushed
the
test/bidirectional-browser-to-browser
branch
from
85567a5
to
6a545b7
Compare
Marcel-G
changed the title
maschad
approved these changes
Jun 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
## [2.0.10](v2.0.9...v2.0.10) (2023-06-12) ### Bug Fixes * add browser-to-browser test for bi-directional communication ([#172](#172)) ([1ec3d8a](1ec3d8a))
|
🎉 This PR is included in version 2.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #173
Before this change, connecting to a webRTC peer over a relay would result in two open connections to the peer. One private-to-private webRTC connection and one relayed connection (used for signalling).
In the browser-to-browser example, dialling B -> A simply returns the first existing connection to A (Added when dialling A -> B). The first connection is not the webRTC connection but rather the relayed connection. This causes the echo to break after the relay is closed or after the reservation expires.
After signalling is complete, the relayed peer connection is no longer needed and can be closed. The connection to the peer is exclusively webRTC at this point.