Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage of MultiplexHandler/Channel #27

Open
Nashatyrev opened this issue Jul 12, 2019 · 2 comments
Open

Test coverage of MultiplexHandler/Channel #27

Nashatyrev opened this issue Jul 12, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Nashatyrev
Copy link
Collaborator

Nashatyrev commented Jul 12, 2019

Cover the MultiplexHandler/Channel classes with unit tests. These are pretty central and non-primitive classes so they should be tested well.
Primary attention should paid to closing child channels, so once the channel is created it must be finally closed. Child channels shouldn't leak.
There are following close circumstances:

  • parent channel is closed
  • remote peer sends RESET signal
  • local peer sends RESET (on channel.close() invoked)
  • remote and local peers sends CLOSE (on channel.disconnect())

Child channels may be created with MultiplexHandler.createStream() asynchronously from any thread and prior to the parent channel is activated. Those cases should also be considered.

@Nashatyrev Nashatyrev added the good first issue Good for newcomers label Jul 12, 2019
@jezhiggins
Copy link
Contributor

While it doesn't cover all the points raised here, I have add some additional multiplex tests in my refactor/multiplex branch.

@arseniy-gl
Copy link

Do it relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants