Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce back-pressure on incoming substreams using new StreamMuxer interface #2796

Closed
thomaseizinger opened this issue Aug 3, 2022 · 0 comments · Fixed by #2861
Closed

Enforce back-pressure on incoming substreams using new StreamMuxer interface #2796

thomaseizinger opened this issue Aug 3, 2022 · 0 comments · Fixed by #2861

Comments

@thomaseizinger
Copy link
Contributor

Once #2722 is complete, I would suggest we inline the HandlerWrapper component into the swarm::Connection struct.

This will resolve some indirection which:

  • Allows us to use the incoming substream limit to enforce back-pressure
  • Simplifies understanding of the code because StreamMuxer and ConnectionHandler are polled by the same component (Connection) and directly pass data between each other instead of going through another layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm/connection: Enforce limit on inbound substreams via StreamMuxer libp2p/rust-libp2p
1 participant
@thomaseizinger