Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor stream::Shared to use internal mutability #170

Open
thomaseizinger opened this issue Jul 20, 2023 · 0 comments
Open

Refactor stream::Shared to use internal mutability #170

thomaseizinger opened this issue Jul 20, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thomaseizinger
Copy link
Contributor

Currently, we hold a stream::Shared within the stream and one in Active. This is shared by being wrapped in Arc<Mutex>.

It would be slightly more ergonomic for both usage sites if the Arc<Mutex> would be inside stream::Shared.
@thomaseizinger thomaseizinger added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomaseizinger