Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Introduce tests for JS-peer #149

Open
maschad opened this issue May 8, 2024 · 2 comments
Open

CI: Introduce tests for JS-peer #149

maschad opened this issue May 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@maschad
Copy link
Member

maschad commented May 8, 2024

It would be good to have a basic ping test akin to the one in js-libp2p ping module to ensure that breaking changes are caught at runtime.

@maschad maschad added the enhancement New feature or request label May 8, 2024
@2color
Copy link
Collaborator

2color commented May 8, 2024

Do the ping module tests in js-libp2p run in the browser?

@maschad
Copy link
Member Author

maschad commented May 8, 2024

Yup, we use aegir to run them

Aegir uses https://github.com/microsoft/playwright under the hood to run the browser tests.

I've also had a good experience using vitest's browser mode as well so that would be my recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants