GPU: More robust error reporting #10958
Open
+816
−855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Sep 26, 2024
slouken
reviewed
Sep 26, 2024
slouken
reviewed
Sep 26, 2024
| if ( | ||
| commandBufferHeader->render_pass.in_progress || | ||
| commandBufferHeader->compute_pass.in_progress || | ||
| commandBufferHeader->copy_pass.in_progress) { | ||
| SDL_assert_release(!"Cannot submit command buffer while a pass is in progress!"); | ||
| return; | ||
| return false; |
There was a problem hiding this comment.
This should set an error (and maybe log in debug mode instead of asserting?)
There was a problem hiding this comment.
An assert is infinitely more useful here for debugging.
There was a problem hiding this comment.
Our intention was to assert in gpu.c in debug mode because the errors we catch there are client misuses.
*David Lynch voice* Imagine fixing CI from your... fucking telephone
TheSpydog
approved these changes
Sep 27, 2024
|
Currently making sure that we're logging errors in debug mode and then this is good to go. |
|
Looks like Haiku CI went down... this should be clear to squash once it's back up and green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10779
I rewrote a lot of error checking so that functions that can fail will bubble up the error to the caller. There is no longer a distinction between logging or setting an error because failures will always set an error. In debug mode the error function will also log.
Commands do not return errors. Since their execution is deferred, the expectation is that the graphics API's validator layer will catch those.
Most graphics errors are not sanely recoverable, but the client can now at least check for errors and report them before crashing.
Needs a Metal implementation before merge.