Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider code of conduct #21

Closed
ctrlcctrlv opened this issue Jun 16, 2021 · 5 comments
Closed

Consider code of conduct #21

ctrlcctrlv opened this issue Jun 16, 2021 · 5 comments
Labels

Comments

@ctrlcctrlv
Copy link
Collaborator

Recent incidents of trolling around #20 have led me to consider whether or not a Code of Conduct is worthwhile for this project.

I've contributed to a lot of open source projects over the years, both those with CoC's and those without. Personally, I find CoC's to be beneficial. But, this is a sensitive issue. So, what do those who are currently working on this or wish to want?

I think this project is the first one that's become large enough and that I've been in any kind of decision making role to have this discussion.

@dankamongmen
Copy link
Collaborator

if you're asking my opinion, i have never thought much of Codes of Conduct, but i certainly won't protest adding one.

i've gotta say, that interaction was a rather shocking one to me -- i hack open source all day, every day, just about, and don't see stuff like that very often.

either way, i'd either add one and close this bug, or don't add one and close this bug, because it's exactly this kind of non-technological thing that people will drop in and ventilate on. =]

@ctrlcctrlv
Copy link
Collaborator Author

@dankamongmen Good to see you online. Do you mind sending me the sixel-encoded graphic mentioned at saitoha#149? I think I fixed the decoder and have a patch ready for PR, but I have no way to test it. The encoder is still b0rked. I'm treating them as separate issues.

@ctrlcctrlv
Copy link
Collaborator Author

My patch fixes the changing palettes issue in the decoder as well. I discovered it was a two for one deal: the root problem is the same in both cases: clumsily juggling palettes.

@ctrlcctrlv
Copy link
Collaborator Author

I mean I suppose I could hand-encode a transparent background Sixel, but it'd be a lot easier just to have one on hand as a test case 😂

@ctrlcctrlv
Copy link
Collaborator Author

Nevermind, figured it out. It's really ugly, much worse than your test case, but behold, the first transparent output from libsixel! :-D

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants