Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to v2 addon #12

Closed
4 tasks done
SergeAstapov opened this issue Mar 30, 2022 · 5 comments
Closed
4 tasks done

Convert to v2 addon #12

SergeAstapov opened this issue Mar 30, 2022 · 5 comments
Labels
breaking enhancement New feature or request

Comments

@SergeAstapov
Copy link
Collaborator

SergeAstapov commented Mar 30, 2022

As this addon provides only run-time functionality hence it's the great candidate for v2 addon conversion.
There is guide great Porting an Addon to V2 guide I suggest we follow.

My thought process of the next steps is to have PRs in the following order:

  1. convert to monorepo Convert to monorepo #13
  2. convert addon to v2 Convert to v2 addon #14
  3. prepare for ember-modifier v4 per migration guide Prepare for ember-modifier v4 #19
  4. release new major v4.0.0

@lifeart do you have any thoughts, concerns? I can volunteer to work on those

@lifeart
Copy link
Owner

lifeart commented Mar 30, 2022

@SergeAstapov all my thumbs up for it!

@SergeAstapov
Copy link
Collaborator Author

@lifeart I think this addon is ready for v4.0.0 to go out

@lifeart
Copy link
Owner

lifeart commented Apr 8, 2022

@SergeAstapov thank you for your work, trying to release it from my PC
image

Manually published v4 https://www.npmjs.com/package/ember-click-outside-modifier, looks like we need to figure out better release process XD (or, likely, I'm missing smf)

@SergeAstapov
Copy link
Collaborator Author

@lifeart thank you for publishing!

@lifeart that error is weird indeed. I wonder if Node.js version had messed up things (just a random thought).
Also, wonder if missing GITHUB_AUTH env variable per Release Process was a culprit.

Anyway I've created #20 to track that issue separately so we can close this one out now!

@SergeAstapov SergeAstapov added enhancement New feature or request breaking labels Apr 8, 2022
@lifeart
Copy link
Owner

lifeart commented Apr 8, 2022

Looks like release-it for windows has incorrect binary configuration..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants