-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to v2 addon #12
Comments
@SergeAstapov all my thumbs up for it! |
@lifeart I think this addon is ready for v4.0.0 to go out |
@SergeAstapov thank you for your work, trying to release it from my PC Manually published v4 https://www.npmjs.com/package/ember-click-outside-modifier, looks like we need to figure out better release process XD (or, likely, I'm missing smf) |
@lifeart thank you for publishing! @lifeart that error is weird indeed. I wonder if Node.js version had messed up things (just a random thought). Anyway I've created #20 to track that issue separately so we can close this one out now! |
Looks like release-it for windows has incorrect binary configuration.. |
As this addon provides only run-time functionality hence it's the great candidate for v2 addon conversion.
There is guide great Porting an Addon to V2 guide I suggest we follow.
My thought process of the next steps is to have PRs in the following order:
ember-modifier
v4 per migration guide Prepare for ember-modifier v4 #19@lifeart do you have any thoughts, concerns? I can volunteer to work on those
The text was updated successfully, but these errors were encountered: