Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting rootUrl causes issues when using ember-fast-cli #8

Closed
evoactivity opened this issue May 26, 2020 · 3 comments · Fixed by #7
Closed

setting rootUrl causes issues when using ember-fast-cli #8

evoactivity opened this issue May 26, 2020 · 3 comments · Fixed by #7

Comments

@evoactivity
Copy link

The cli is served on localhost:4200/cli but the language server is looking for localhost:4200/rootUrl/cli
@lifeart
Copy link
Owner

lifeart commented May 26, 2020

Hi @evoactivity thank you for report! Language server using data from meta.json, generated in
https://github.com/lifeart/ember-fast-cli/blob/master/index.js#L164

Will check how it may be fixed (basically, I'm using default serving logic)

@lifeart
Copy link
Owner

lifeart commented May 26, 2020

@evoactivity could you test this branch? #7

@lifeart
Copy link
Owner

lifeart commented May 26, 2020

fixed in [email protected], @evoactivity thank you for report!

@lifeart lifeart transferred this issue from lifeart/ember-language-server May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: setting rootUrl causes issues when using ember-fast-cli #128 lifeart/ember-fast-cli
2 participants
@evoactivity @lifeart