Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiMa Logger trait is now private; makes MiMaLib constructor unusable #547

Closed
kelnos opened this issue Sep 11, 2020 · 1 comment · Fixed by #549
Closed

MiMa Logger trait is now private; makes MiMaLib constructor unusable #547

kelnos opened this issue Sep 11, 2020 · 1 comment · Fixed by #549
Milestone

Comments

@kelnos
Copy link

kelnos commented Sep 11, 2020

Hi, I'm the maintainer of https://github.com/kelnos/mima-maven-plugin. I was just trying to update the plugin for 0.8.0, but found that the Logging trait has been made private (67fb8d4). However, the MiMaLib constructor requires that I pass a param of type Logging if I want to customize logging behavior (which I do, so I can use maven's logger). Is it possible to make Logger public again?

In the meantime I suppose I can implement the trait by using the same-package-name trick, but that seems less than ideal from an interface/API perspective.

@dwijnand
Copy link
Collaborator

Yep, I'll make that logging interface accessible again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants