-
-
Notifications
You must be signed in to change notification settings - Fork 193
Add release steps to serve Helm Charts Repository on Github Pages #183
Conversation
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
Hi @akozich, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. I'll test this out in a release later this week.
Hey @akozich . I ran this as part of the 0.6.6 release, but it doesn't seem to add or push the chart repo artifacts in the gh-pages branch. I see a |
I'll study this more later. In the meantime I manually published the chart repo here: http://lightbend.github.io/kafka-lag-exporter/repo/index.yaml |
Hey @seglo . |
As I can see |
I created it manually when I didn't see it after the release. |
I'll play around with it before the next release. Was it intended for the repo |
Currently Helm Charts are attached to Github Release. It's enough to install chart as is.
In our case we had to extend it with our deployment specific resources. The most correct way was to make our own chart having
kafka-lag-exporter
as a dependency. But in order to specify a dependency chart must he stored in Helm Charts Repository.In this PR I've added few steps to serve Helm Charts Repository on Github Pages as explained here https://helm.sh/docs/topics/chart_repository/.
Changes summary:
helm index
providing existing index to build a new repository index