Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving Scala 3 artifacts #624

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented May 5, 2021

Fixes #613 See the discussion there.

The test currently fails with:

~~~ text
[info] [error] sbt.librarymanagement.ResolveException: Error downloading com.example:scala-3-mima_3.0.0-RC3_3.0:1.0.0-SNAPSHOT
[info] [error]   Not found
[info] [error]   not found: /home/julien/.ivy2/local/com.example/scala-3-mima_3.0.0-RC3_3.0/1.0.0-SNAPSHOT/ivys/ivy.xml
[info] [error]   not found: https://repo1.maven.org/maven2/com/example/v1-0-1_3.0.0-RC3_3.0/1.0.0-SNAPSHOT/scala-3-mima_3.0.0-RC3_3.0-1.0.0-SNAPSHOT.pom
[info] [error]  at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:258)
[info] [error]  at lmcoursier.CoursierDependencyResolution.$anonfun$update$38(CoursierDependencyResolution.scala:227)
[info] [error]  at scala.util.Either$LeftProjection.map(Either.scala:573)
[info] [error]  at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:227)
[info] [error]  at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
[info] [error]  at com.typesafe.tools.mima.plugin.SbtMima$.getPreviousArtifact(SbtMima.scala:98)
[info] [error]  at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$5(MimaPlugin.scala:50)
[info] [error]  at scala.collection.Iterator$$anon$10.next(Iterator.scala:461)
[info] [error]  at scala.collection.Iterator.foreach(Iterator.scala:943)
[info] [error]  at scala.collection.Iterator.foreach$(Iterator.scala:943)
[info] [error]  at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
[info] [error]  at scala.collection.generic.Growable.$plus$plus$eq(Growable.scala:62)
[info] [error]  at scala.collection.generic.Growable.$plus$plus$eq$(Growable.scala:53)
[info] [error]  at scala.collection.immutable.Map$MapBuilderImpl.$plus$plus$eq(Map.scala:647)
[info] [error]  at scala.collection.immutable.Map$MapBuilderImpl.$plus$plus$eq(Map.scala:594)
[info] [error]  at scala.collection.TraversableOnce.toMap(TraversableOnce.scala:372)
[info] [error]  at scala.collection.TraversableOnce.toMap$(TraversableOnce.scala:370)
[info] [error]  at scala.collection.AbstractIterator.toMap(Iterator.scala:1431)
[info] [error]  at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$4(MimaPlugin.scala:51)
[info] [error]  at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[info] [error]  at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[info] [error]  at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[info] [error]  at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[info] [error]  at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[info] [error]  at sbt.Execute.work(Execute.scala:291)
[info] [error]  at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[info] [error]  at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[info] [error]  at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[info] [error]  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[info] [error]  at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[info] [error]  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[info] [error]  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[info] [error]  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[info] [error]  at java.base/java.lang.Thread.run(Thread.java:834)
[info] [error] (v1-0-1 / mimaPreviousClassfiles) sbt.librarymanagement.ResolveException: Error downloading com.example:scala-3-mima_3.0.0-RC3_3.0:1.0.0-SNAPSHOT
[info] [error]   Not found
[info] [error]   not found: /home/julien/.ivy2/local/com.example/scala-3-mima_3.0.0-RC3_3.0/1.0.0-SNAPSHOT/ivys/ivy.xml
[info] [error]   not found: https://repo1.maven.org/maven2/com/example/scala-3-mima_3.0.0-RC3_3.0/1.0.0-SNAPSHOT/scala-3-mima_3.0.0-RC3_3.0-1.0.0-SNAPSHOT.pom
[info] [error] Total time: 1 s, completed May 4, 2021, 3:15:03 PM
[error] x sbt-mima-plugin/scala-3
~~~
@julienrf julienrf mentioned this pull request May 5, 2021
Copy link
Collaborator

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it. I'm almost inclined to say that the fact that this is required is right, and it was accidentally or even erroneously working before.

@dwijnand dwijnand changed the title Support Scala 3 Fix resolving Scala 3 artifacts May 5, 2021
@dwijnand dwijnand merged commit 1e4d7b4 into lightbend-labs:main May 5, 2021
@julienrf julienrf deleted the scala-3 branch May 5, 2021 15:49
@dwijnand dwijnand added this to the 0.9.1 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Dotty resolution issue
2 participants