Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After prepayment fails lnd keeps trying to pay the swap, delaying failure notification. #740

Open
gtochim opened this issue May 7, 2024 · 4 comments

Comments

@gtochim
Copy link

gtochim commented May 7, 2024

A successful loop out involves two off chain payments: the prepay and the swap.

If the prepay fails early, the swap is bound to fail, but loop never communicates to lnd that it should stop trying to make this payment.

Once one of the offchain payment fails, we should ask lnd to "stop trying" to fulfill the other payment. We can't rely on lnd's timeout, since loop sets this to 60 minutes (this makes sense, since the swap payments might take a while to find a route).

Edit:

I'm on version v0.23.0-beta

@gtochim
Copy link
Author

gtochim commented May 7, 2024

Additionally, if lnd eventually failed the payment with a timeout, we would continue to retry it.

@alexbosworth
Copy link
Member

LND doesn't have an API that allows stopping trying a payment, but at a high level yeah potentially things can be improved here

Can you include the version of loopd you are using in the issue?

@gtochim
Copy link
Author

gtochim commented May 7, 2024

I'm aware LND doesn't have that API, but I would be glad to open an issue in lnd's repo about it.

@alexbosworth
Copy link
Member

Great yeah, there may be stuff we can do to workaround it but I can confirm that we do have this in-flight issue because of the lack of the cancel API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants