Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using higher version of angular #244

Closed
gottfrois opened this issue Jun 4, 2015 · 8 comments
Closed

Allow using higher version of angular #244

gottfrois opened this issue Jun 4, 2015 · 8 comments
Assignees

Comments

@gottfrois
Copy link

Hey guys,

Is it possible to allow angular version >= 1.3.x ? I'm currently using angular 1.4 release candidate for my project and as a result I have 2 angular version loaded.

Thanks.

@egor-smirnov
Copy link
Member

There is one open issue for Angular 1.4 - #243. It blocks us from bumping Angular version in package.json / bower.json.

Will revisit this issue after solving #243

@gottfrois
Copy link
Author

Issue seems fixed, would it be possible now to allow angular 1.4.x please ?

@jorn86
Copy link

jorn86 commented Aug 4, 2015

For some reason, Bower still tells me "ngDialog#0.4.0 depends on angular#~1.3.x which resolved to angular#1.3.17". 0.4.0 seems to be the latest version, in which this should be fixed.
Any suggestions?

@egor-smirnov
Copy link
Member

@jorn86 that's because new version is not published to bower / npm. Please use master branch.
@voronianski I guess it's time to publish next version to bower / npm to avoid further confusion. Could you do that?

@jbimberg
Copy link

jbimberg commented Aug 5, 2015

+1 (although there is an issue with angular 1.4 and animations which prevents ngDialogs from being closed... but this can be worked around by setting disableAnimation to true when opening an ngDialog)

@egor-smirnov
Copy link
Member

@jbimberg seems strange that it doesn't work with Angular 1.4. We are using Angular 1.4 with latest version of ngDialog at https://github.com/likeastore/ngDialog/blob/master/example/index.html. It works well so far.

I guess we might need more specific code examples for your case. Consider opening new issue for that and don't forget to prepare code example.

@jbimberg
Copy link

jbimberg commented Aug 6, 2015

Sorry, you are right, animated close works. I omitted some css when adapting the styles to my project's, wasn't aware that application logic might be css-sensitive.

@brunomperes
Copy link

Does the upgrade break when using angular 1.3.x ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants