Close button should be a button

[thany]

What version of ng-dialog are you using?
0.6.4

What version of AngularJS are you using?
1.5.8

What browsers are affected?
All/not applicable.

Please describe the issue
The close button is curently hardcoded as <div class="ngdialog-close"></div>. This is bad for accessibility. It should rather be a button element with proper content, e.g. <button type=button class=ngdialog-close>Close</button>. Should probably also get an aria-label attribute, esp. when putting just an "X" in it.

Button content should probably be an option for i18n primarily. Setting this in css with a ::before is a bad idea as well: it's just as bad for accessibility and it makes i18n harder.

[skarkkai-p]

Isn't this fixed in #533?

[thany]

Looks like it. If it's released, I can give it a go.

[ghost]

while testing with JAWS for accessibility, the close/ dismiss button is not navigable by keyboard, on adding character within the button, it becomes navigable by keyboard. i'm assuming   would work as well, alternatively, adding tabindex=0 might work too. but in order to try it out, we need a way to customize it.

can this be taken up as priority?