Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button looks and behave strange across broswers #563

Closed
fhurta opened this issue Jul 27, 2017 · 1 comment · Fixed by #564
Closed

Close button looks and behave strange across broswers #563

fhurta opened this issue Jul 27, 2017 · 1 comment · Fixed by #564

Comments

@fhurta
Copy link
Contributor

fhurta commented Jul 27, 2017

I used ngDialog in my app and noticed strange look of the close button in Chrome. When trying in FF and IE11, it looks differently and in FF the click on the cross does not work at all (only clicking on the very small button itself).

I compared it to your Demo where it looks and works well. In the end I've noticed that while in the Demo the close button is rendered as <div>, in my case it is rendered as <button>. When I changed the element in browser dev tools to <div> it worked fine in all 3 tested browsers.

I open the dialog using ngDialog.open() method.

ngDialog 1.3.0
angularJs 1.6.5
browsers tested: Chrome current, FF current, IE 11
Test at: https://codepen.io/exavier/full/NvqOgB/

@fhurta
Copy link
Contributor Author

fhurta commented Jul 27, 2017

Seems #533 is the source of problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant