-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make minimal is too minimal, does not install all templates #2641
Comments
This is already proposed in #2638 (except it has separate So I think this issue could be closed as a duplicate. |
This was supposed to be done by supplying a I think we could move the Source installation to a separate page? https://lima-vm.io/docs/installation/
|
Also in CI it should not be a major issue, if the build results are being put in the CI cache? i.e. there is no need to install go and to build it from source, if there already is a binary... |
It depends on what you want to test. I want to lima from master in the ramen CI so we can validate that ramen code using lima does not break because of new changes in lima. The CI runners are very slow and building lima can take more than 10 minutes for a full build. |
Sorry about your CI runners, I just find the cache to be even more valuable on the small systems like the Raspberry Pi... It is off-topic to the discussion on what to build and install with |
The makefile now has |
Description
This is what I'm doing in CI to get a minimal build (since it takes 4 minutes instead of 11 minutes), and use the vmnet template:
Possible fixes:
Install all templates in make minimal
Provide a templates target to install all templates, so user can do:
The second option seems better, keeping the current behavior, and providing more options for developers with special needs.
I can post a PR if we have an agreement on the wanted solution.
The text was updated successfully, but these errors were encountered: