-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider disabling sshfs caching by default #600
Comments
I don't understand why disabling cache breaks their application, but disabling cache is generally safer than enabling it, no? Maybe Rancher Desktop should just have a GUI checkbox to toggle the caching configuration? |
It is not "their application", it seems to be breaking PHP. I can consistently reproduce the issue that I have tried to look into it, but haven't found anything yet. Intuitively I would also think that disabling caching should be safer, but at least in the case of PHP it doesn't seem to be true. @rfay Do you have any new/additional insight into this problem?
Of course, but I'm just talking about lima here. This is a regression in lima 0.8.1 relative to 0.8.0, and I wonder now what the benefits of disabling caching are that makes it worth it breaking compatibility with PHP. I still would like to understand what is going on first, but I suspect both colima and Rancher Desktop will re-enable caching by default again, to fix the regression, and it would make sense to me for lima to do the same. |
The bottom line is we need to get rid of sshfs :) I had severe problems with caching enabled, then more severe (different kind) with it disabled. So could be something with lima 0.8.1 for sure. I was baffled by the result. |
@rfay So which problems were worse? 😄 I have one update: After deleting |
It was worse with caching turned off. But completely different problems. Both automated testing discoveries. So high pressure situations, unlike a normal person working away. |
For me both I wonder if @rfay's failures with caching enabled have been observed by anybody else, or if it was just in the automated CI environment. |
This was already proposed in PR #556.
So far we just made the setting configurable, but the default is still
cache=no
.Given the problems reported in #556 and elsewhere, e.g. rancher-sandbox/rancher-desktop#1349, I wonder if we shouldn't have reverted the default as well when we made the setting configurable.
The text was updated successfully, but these errors were encountered: