Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A DnsTimeoutException should also set true to ctx.isTimedOut(). #4935

Closed
trustin opened this issue Jun 9, 2023 · 2 comments · Fixed by #5156
Closed

A DnsTimeoutException should also set true to ctx.isTimedOut(). #4935

trustin opened this issue Jun 9, 2023 · 2 comments · Fixed by #5156
Assignees
@injae-kim
Labels
defect
Milestone
1.30.0

Comments

@trustin
Copy link
Member

trustin commented Jun 9, 2023

Related:

We need to make sure CancellationScheduler.finishNow(TimeoutException) is invoked on more timeout types such as session/connection/DNS timeout so that true is set to ctx.isTimedOut().

/cc @injae-kim
@trustin trustin added the defect label Jun 9, 2023
@trustin trustin added this to the 1.25.0 milestone Jun 9, 2023
@injae-kim
Copy link
Contributor

Please assign this issue to me~! I'll make PR soon 🙇 thanks!

@jrhee17 jrhee17 modified the milestones: 1.25.0, 1.26.0 Aug 15, 2023
@injae-kim
Copy link
Contributor

(Sorry for late, I'll make PR until 8/31 🙇)

@injae-kim injae-kim mentioned this issue Aug 29, 2023
Merged
@minwoox minwoox modified the milestones: 1.26.0, 1.27.0 Oct 11, 2023
@ikhoon ikhoon modified the milestones: 1.27.0, 1.28.0 Jan 16, 2024
@jrhee17 jrhee17 modified the milestones: 1.28.0, 1.29.0 Mar 19, 2024
@jrhee17 jrhee17 modified the milestones: 1.28.0, 1.29.0 Apr 8, 2024
@minwoox minwoox modified the milestones: 1.29.0, 1.30.0 May 21, 2024
@ikhoon ikhoon closed this as completed in 4c6f0ff Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@injae-kim injae-kim

Labels
defect
Projects
None yet
Milestone
1.30.0
Development

Successfully merging a pull request may close this issue.

Set RequestContext.isTimedOut(true) on DNS, session, write timeout injae-kim/armeria
5 participants
@trustin @ikhoon @jrhee17 @minwoox @injae-kim