fix: Modify omission of change to change ValidatorSet to VoterSet for marverick

[Kynea0b]

Description

Corresponding to the omission of change from the validator set to the voter set during version upgrade work.
This commit change was not reflected.25fe25c

This PR is an additional modification of this PR #340

[codecov]

Codecov Report

Merging #345 (badbaa6) into main (b628591) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head badbaa6 differs from pull request most recent head 2bac1b2. Consider uploading reports for the commit 2bac1b2 to get more accurate results

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   63.00%   63.01%   +0.01%     
==========================================
  Files         272      272              
  Lines       30286    30253      -33     
==========================================
- Hits        19081    19064      -17     
+ Misses       9475     9461      -14     
+ Partials     1730     1728       -2     

Impacted Files	Coverage Δ
p2p/peer.go	62.80% <100.00%> (+1.62%)	⬆️
libs/events/events.go	93.20% <0.00%> (-4.86%)	⬇️
blockchain/v1/reactor.go	69.62% <0.00%> (-3.08%)	⬇️
crypto/bls/bls.go	48.41% <0.00%> (-2.39%)	⬇️
p2p/pex/pex_reactor.go	79.58% <0.00%> (-1.05%)	⬇️
abci/client/socket_client.go	75.85% <0.00%> (-1.03%)	⬇️
blockchain/v0/reactor.go	68.01% <0.00%> (-0.91%)	⬇️
statesync/syncer.go	78.62% <0.00%> (-0.77%)	⬇️
state/execution.go	68.09% <0.00%> (-0.66%)	⬇️
p2p/switch.go	67.09% <0.00%> (-0.52%)	⬇️
... and 13 more

[torao]

LGTM

[tnasu]

Could you also update CONTRIBUTING.md? Should it change in ./test/maverick/node?

https://github.com/line/ostracon/blob/main/CONTRIBUTING.md#maverick

If you're changing the code in consensus package, please make sure to replicate all the changes in ./test/maverick/consensus. Maverick is a byzantine node used to assert that the validator gets punished for malicious behavior.

[Kynea0b]

@tnasu
Thank you for your pointing out.

Could you also update CONTRIBUTING.md? Should it change in ./test/maverick/node?

CONTRIBUTING.md does not need to be changed.

If you're changing the code in consensus package, please make sure to replicate all the changes in ./test/maverick/consensus. Maverick is a byzantine node used to assert that the validator gets punished for malicious behavior.

It means that the code change in consensus package should be applied to this path ./test/maverick/consensus as well, so I think there is no problem with the previous #340 and current this PR.

[tnasu]

Sorry for my misleading. I mean that I want to change the sentence to the below:

If you're changing the code in consensus or node package, please make sure to replicate all the changes in ./test/maverick/consensus and ./test/maverick/node. Maverick is a byzantine node used to assert that the validator gets punished for malicious behavior.

[Kynea0b]

@tnasu
OK. I will fix it.