From 7cb22a9cac82c88908b3e66d7ac927546ce9eff4 Mon Sep 17 00:00:00 2001
From: Rod S <rsheeter@google.com>
Date: Thu, 10 Nov 2022 19:39:19 -0800
Subject: [PATCH] code review

---
 src/designspace.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/designspace.rs b/src/designspace.rs
index 48020b08..0fdb8368 100644
--- a/src/designspace.rs
+++ b/src/designspace.rs
@@ -79,8 +79,9 @@ pub struct Instances {
 /// [instance]: https://fonttools.readthedocs.io/en/latest/designspaceLib/xml.html#instance-element
 #[derive(Clone, Debug, Default, PartialEq, Deserialize)]
 pub struct Instance {
-    pub familyname: String,
-    pub stylename: String,
+    // per @anthrotype, contrary to spec, familyname and stylename are optional
+    pub familyname: Option<String>,
+    pub stylename: Option<String>,
     pub name: String,
     pub filename: String,
     pub postscriptfontname: Option<String>,