Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f64 for floating point numbers #164

Closed
madig opened this issue Aug 19, 2021 · 2 comments · Fixed by #184
Closed

Use f64 for floating point numbers #164

madig opened this issue Aug 19, 2021 · 2 comments · Fixed by #184

Comments

@madig
Copy link
Collaborator

madig commented Aug 19, 2021

Python apparently uses f64 internally for floats but norad uses f32. This leads to vanilla Python code and norad to read the odd floating point coordinate differently (the f32 is upconverted to f64 in PyO3 bindings, changing the precision and making equality testing difficult). Maybe norad should use f64 where the spec talks about floats?

@cmyr
Copy link
Member

cmyr commented Aug 19, 2021

fine by me!

@madig
Copy link
Collaborator Author

madig commented Sep 15, 2021

A designer notified me that this is especially annoying with e.g. guideline angles because they often happen to have a lot of decimal places. When multiple tools read and write those and keep higher precision, norad will always "shorten" them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants