Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform unsupported PresentMode in create_surface can cause unrecoverable panic, with no fallback behavior #721

Open
xorgy opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xorgy
Copy link
Member

xorgy commented Oct 22, 2024

If you provide a PresentMode in RenderContext::create_surface which is not supported by the platform (e.g. Immediate or FifoRelaxed while on Wayland), it will panic while configuring the surface. The only current way to work around this with released Vello is to write your own version of portions of util.

It may be more helpful to have safe fallback (probably AutoVsync) here, since this is meant to be a convenience function.

@xorgy xorgy added the enhancement New feature or request label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant