Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use fire, and use good old argparse #418

Open
doronbehar opened this issue Aug 2, 2024 · 0 comments
Open

Don't use fire, and use good old argparse #418

doronbehar opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@doronbehar
Copy link
Contributor

doronbehar commented Aug 2, 2024

Hello @bleykauf .

I just managed to install the server in an offline manner (more details about that experience in #378 (comment) ). This dependency is problematic and it is not worth it IMO. Here's why:

First of all, there's this upstream issue which very annoyed me when I wanted to use the new CLI interface for the first time. It took me ~half an hour to explain exactly what was wrong and to find out that it was the library's fault.

Secondly, they don't distribute a .whl file to pypi which was a bit annoying in one of my attempts to iterate the dependencies of the server when trying to send them all via ssh (this is mentioned in this pip issue.

And lastly, for target hosts without a real internet connection, it is generally useful to reduce the number of dependencies.

I can help with the transition to argparse, but I seek your approval on the subject first.

@doronbehar doronbehar added the bug Something isn't working label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant