Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sameAs automatic node merging by default #458

Closed
timbl opened this issue Nov 21, 2020 · 1 comment
Closed

Disable sameAs automatic node merging by default #458

timbl opened this issue Nov 21, 2020 · 1 comment

Comments

@timbl
Copy link
Member

timbl commented Nov 21, 2020

https://github.com/linkeddata/rdflib.js/blob/master/src/store.ts#L198

sets the default mode for a Store to implement 'smushing' of nodes together in the graph. This is not something standard functionality, and may confuse future developers.

These features were used in the mashlib when it was used in the old says of 'mashups', to when combining data from many trusted open data sources, like the network of FOAF files. In fact the FOAF ontology specifically identify people by having the same properties, such as same email address or hash or email address.

But nowadays in the solid world, the data is from different resources has very different trust and this technique is not so appropriate. Anyway it is I think reasonable to expect devs in future who want to use the features to turn them on explicitly.

This is formally a breaking change to the API though I doubt many people even know about the features. This will of improve RDF/JS compatibility.

@timbl
Copy link
Member Author

timbl commented Apr 30, 2021

Fixed by #492

@timbl timbl closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant