Add --script-file-path to run a user script #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… booted, but before tests are run
oliverhu
reviewed
Oct 24, 2018
Source/Shared/BPConfiguration.m
Outdated
| @@ -141,6 +141,8 @@ typedef NS_OPTIONS(NSUInteger, BPOptionType) { | |||
| "Directory where simulator screenshots for failed ui tests will be stored"}, | |||
| {362, "simulator-preferences-file", BP_MASTER | BP_SLAVE, NO, NO, required_argument, NULL, BP_VALUE | BP_PATH, "simulatorPreferencesFile", | |||
| "A .GlobalPreferences.plist simulator preferences file to be copied to any newly created simulators before booting"}, | |||
| {363, "script-file-path", BP_MASTER | BP_SLAVE, NO, NO, required_argument, NULL, BP_VALUE | BP_PATH, "scriptFilePath", | |||
| @@ -0,0 +1,5 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # This is a script to test --script-file-path | |||
| XCTAssert(exitCode2 == BPExitStatusSimulatorDeleted); | ||
| XCTAssertEqualObjects(self.config.deleteSimUDID, bp2.test_simulatorUDID); | ||
|
|
||
| XCTAssertFalse([[NSFileManager defaultManager] fileExistsAtPath:testFile]); |
There was a problem hiding this comment.
please also delete the testfile after this test finishes
oliverhu
reviewed
Oct 24, 2018
| @@ -718,6 +720,18 @@ - (BOOL)validateConfigWithError:(NSError *__autoreleasing *)err { | |||
| } | |||
| } | |||
|
|
|||
| if (self.scriptFilePath) { | |||
| if ([[NSFileManager defaultManager] fileExistsAtPath:self.scriptFilePath isDirectory:&isdir]) { | |||
| if (isdir) { | |||
There was a problem hiding this comment.
Also make sure this file is executable
- rename script-file-path option to script-file - rename script.sh file to test-script.sh - if test file is not removed by sim delete, remove in test - check to see if the script is executable
|
@oliverhu all comments addressed in latest commit |
oliverhu
approved these changes
Oct 25, 2018
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to run a script after a simulator is booted, but before tests are run. One reason to use this is to install certificates to integrate with mitmproxy (per #194)