discover: Timeout stalled resolutions #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a load balancer is not polled, i.e. because it is idle/leaked, its resolution stream can fill up, causing backpressure onto the destination controller client. This change implements a timeout for this scenario. When the resolution buffer is at capacity for a full idle timeout, the background resolution completes to free its resources.
seanmonstar
approved these changes
Dec 18, 2019
hawkw
approved these changes
Dec 18, 2019
|
If the balanacer were to start consuming from the queue again, it would get an error when the queue is fully consumed and fail (which is what we'd hope). |
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 18, 2019
This release adds a defense mechanism to ensure that resolutions are released when the associated balancer becomes idle and should have been dropped from the proxy. Furthermore, the proxy is now more selective as to which gRPC status codes are considered "failures" in metrics. --- * Classify some gRPC status codes as non-errors (linkerd/linkerd2-proxy#395) * discover: Timeout stalled resolutions (linkerd/linkerd2-proxy#401)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 19, 2019
This release adds a defense mechanism to ensure that resolutions are released when the associated balancer becomes idle and should have been dropped from the proxy. Furthermore, the proxy is now more selective as to which gRPC status codes are considered "failures" in metrics. --- * Classify some gRPC status codes as non-errors (linkerd/linkerd2-proxy#395) * discover: Timeout stalled resolutions (linkerd/linkerd2-proxy#401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a load balancer is not polled, i.e. because it is idle/leaked, its
resolution stream can fill up, causing backpressure onto the destination
controller client.
This change implements a timeout for this scenario. When the resolution
buffer is at capacity for a full idle timeout, the background resolution
completes to free its resources.