Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm upgrade always changing due to trust root? #12668

Closed
kastl-ars opened this issue May 31, 2024 · 3 comments
Closed

Helm upgrade always changing due to trust root? #12668

kastl-ars opened this issue May 31, 2024 · 3 comments
Assignees

Comments

@kastl-ars
Copy link

What is the issue?

#4017 was closed as solved, but if I understand the issue properly I am still having the same problem.

Running helm upgrade ... directly after running helm install ..., i.e. without any changes due to helm chart versions etc., always does something and is not idempotent.

How can it be reproduced?

Run this command:

helm install linkerd-control-plane -n linkerd \
  --set-file identityTrustAnchorsPEM=ca.crt \
  --set-file identity.issuer.tls.crtPEM=issuer.crt \
  --set-file identity.issuer.tls.keyPEM=issuer.key \
  linkerd/linkerd-control-plane

Then immediately run this command (that uses upgrade instead of install):

helm upgrade linkerd-control-plane -n linkerd \
  --set-file identityTrustAnchorsPEM=ca.crt \
  --set-file identity.issuer.tls.crtPEM=issuer.crt \
  --set-file identity.issuer.tls.keyPEM=issuer.key \
  linkerd/linkerd-control-plane

You end up with changes and two versions in the helm history, even though nothing should have changed. The files are the same, no chart updates have been found in the mean time.

Logs, error output, etc

Only the normal helm output when a chart is being installed/updated.

output of linkerd check -o short

Status check results are √

Environment

  • Kubernetes v1.29.5+k3s1

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

None

@kastl-ars kastl-ars added the bug label May 31, 2024
@adleong
Copy link
Member

adleong commented Jun 5, 2024

Hi @kastl-ars! There are certain resources which are always regenerated on install or upgrade, such as the TLS credentials for webhooks. There isn't any need for continuity of these credentials through upgrades. Can you tell me more about your use case? Why would you run a helm upgrade with no changes and why would you not want this upgrade to appear in the helm history?

@kastl-ars
Copy link
Author

I noticed because I was preparing a setup using linkerd in k3s, where Ansible and Vagrant deployed everything. Except that Ansible always reported things as changed and the pods kept being restarted on upgrade.

#4017 sounded like this kind of issue should no longer appear, hence this bug report. If this intentional, then feel free to close it.

Copy link

stale bot commented Sep 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 14, 2024
@stale stale bot closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants